Bug detected in PO_Items SQL

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Bug detected in PO_Items SQL

Pak Ricard
Hi all:

After we rolled up to 4.13 we discovered a bug in PO_Items.php

Because on the new version SupplierItemsOnly is set to on as default, when user selects an item with more than 1 row at purchdata table for that specific supplier, it is shown N times to the user.

If the flag SupplierItemsOnly is unchecked, SQL returns the correct rows as it does not need to do the INNER JOIN purchdata

Even if SupplierItemsOnly is set to "on" it should only show 1 row for each supplier

I just fixed it in commit 7583 adding some "GROUP BY stockmaster.stockid" but I would like a senior revision of my commit as it's a critic script and I'm not so used to it to be 100% confident

Regards,
Ricard

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers