Quantcast

Bug in GLAccountInquiry

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Bug in GLAccountInquiry

Pak Ricard
Hi Exson:

I am using the latest scripts with your nice upgrades. Happy with them, buit I think there's a bug aroung lines 278 to 292 in GLAccountInquiry.php, as I am getting wrong results. The field Bank Reference is shown with wrong data, as it shows data from diferent transactions.

Am I the only one having thses issues?

 
Regards,
Ricard

------------------------------------------------------------------------------

_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

ExsonQu
Administrator
Hi, Richard,

               Thank you for your test!

               Since this change looks strange to accounts, it'll be reversed. So I did not fix the bug.
               I believe there are lots of small companies which have no accounts and GL account inquiry is not only for accountants to review.
               If there are more feedback about reserving this, I'll change it as option instead of removing from the trunk.

              Best regards!

              Exson
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

Pak Ricard
Hi Exson:

I think the idea is good and helpful, just we are showing the wrong results for any reason.

Regards,
Ricard

2015-11-16 5:58 GMT+08:00 ExsonQu <[hidden email]>:
*Hi, Richard,*

               Thank you for your test!

               Since this change looks strange to accounts, it'll be
reversed. So I did not fix the bug.
               I believe there are lots of small companies which have no
accounts and GL account inquiry is not only for accountants to review.
               If there are more feedback about reserving this, I'll change
it as option instead of removing from the trunk.

              Best regards!

              Exson



--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Bug-in-GLAccountInquiry-tp4658408p4658418.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

------------------------------------------------------------------------------
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers


------------------------------------------------------------------------------
Presto, an open source distributed SQL query engine for big data, initially
developed by Facebook, enables you to easily query your data on Hadoop in a
more interactive manner. Teradata is also now providing full enterprise
support for Presto. Download a free open source copy now.
http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

Rafael Chacón
Hi,

I am testing GLAccountInquiry.php. Could you give me more details about what is wrong?

Best regards, Rafael.

2015-11-15 21:09 GMT-06:00 Pak Ricard <[hidden email]>:
Hi Exson:

I think the idea is good and helpful, just we are showing the wrong results for any reason.

Regards,
Ricard

<a href="tel:2015-11-16" value="+50620151116" target="_blank">2015-11-16 5:58 GMT+08:00 ExsonQu <[hidden email]>:
*Hi, Richard,*

               Thank you for your test!

               Since this change looks strange to accounts, it'll be
reversed. So I did not fix the bug.
               I believe there are lots of small companies which have no
accounts and GL account inquiry is not only for accountants to review.
               If there are more feedback about reserving this, I'll change
it as option instead of removing from the trunk.

              Best regards!

              Exson



--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Bug-in-GLAccountInquiry-tp4658408p4658418.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

------------------------------------------------------------------------------
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers


------------------------------------------------------------------------------
Presto, an open source distributed SQL query engine for big data, initially
developed by Facebook, enables you to easily query your data on Hadoop in a
more interactive manner. Teradata is also now providing full enterprise
support for Presto. Download a free open source copy now.
http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers



------------------------------------------------------------------------------

_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

Pak Ricard
Hi Rafael:

In my tests, the new fields showing the details of the transaction, sometimes are right and sometimes wrong. Could not detect any exact pattern. 

But, as example, expenses reported from the Petty Cash Module ($type = 1) are incorrectly shown in this new version of GLAccountInquiry. Probably the query in line 280 doesn't extract the data correctly (sorry, I had no time to check the problem in detail, and commented it out on my installation).

I remember Tim reported the same bug as well, probably he remembers more details about it.

Anyway, just let me know if you need any test done. 

Regards,
Ricard

2015-12-30 3:05 GMT+08:00 Rafael Chacón <[hidden email]>:
Hi,

I am testing GLAccountInquiry.php. Could you give me more details about what is wrong?

Best regards, Rafael.

2015-11-15 21:09 GMT-06:00 Pak Ricard <[hidden email]>:
Hi Exson:

I think the idea is good and helpful, just we are showing the wrong results for any reason.

Regards,
Ricard

<a href="tel:2015-11-16" value="+50620151116" target="_blank">2015-11-16 5:58 GMT+08:00 ExsonQu <[hidden email]>:
*Hi, Richard,*

               Thank you for your test!

               Since this change looks strange to accounts, it'll be
reversed. So I did not fix the bug.
               I believe there are lots of small companies which have no
accounts and GL account inquiry is not only for accountants to review.
               If there are more feedback about reserving this, I'll change
it as option instead of removing from the trunk.

              Best regards!

              Exson



--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Bug-in-GLAccountInquiry-tp4658408p4658418.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

------------------------------------------------------------------------------
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers


------------------------------------------------------------------------------
Presto, an open source distributed SQL query engine for big data, initially
developed by Facebook, enables you to easily query your data on Hadoop in a
more interactive manner. Teradata is also now providing full enterprise
support for Presto. Download a free open source copy now.
http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers



------------------------------------------------------------------------------

_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers



------------------------------------------------------------------------------

_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

ExsonQu
Administrator
Hi, Richard,

            Thank you for your report!

           I've uploaded the new version to the trunk. Please check if it's fixed.

          Thanks and best regards!

          Exson
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

Pak Ricard
Hi Exson:

Thanks for the fix. We still have some problems with the Petty Cash. Please check the screenshot:
Imatge inserida 1 
IDR is the default currency, so 3rd entry should be 300.000 and 4th should be 500.000 

Regards,
Ricard

2016-01-11 18:18 GMT+08:00 ExsonQu <[hidden email]>:
*Hi, Richard,*

            Thank you for your report!

           I've uploaded the new version to the trunk. Please check if it's
fixed.

          Thanks and best regards!

          Exson



--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Bug-in-GLAccountInquiry-tp4658408p4658459.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

ExsonQu
Administrator
Hi, Richard,

             Thank you for your feedback.
             I think the error is caused partially due to the last variable not be refreshed. But there is other problem for this. What is the transaction type of 8365 and 8367?

            Thanks and best regards!

            Exson
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

Pak Ricard
Hi Exson:

Thanks for your fast reply.

Type = 2 (Recepit-GL). This is the gltrans records for 1 of them

Imatge inserida 1
I also run: SELECT * FROM `gltrans` WHERE `type` = 2 AND `typeno` = 8365 and the result are exactly the same 2 rows

I'm afraid the problem comes from banktrans table, as PC tabs do not record banktrans transactions except when it's an "assigncash" movement and it records the bank account source of the funds transferred to the PC tab (as in this examples I used), using the type = 1

I coded the Petty Cash long time ago, and can't remember any problem with this, but probably the PCAuthorizeExpenses.php line 214 should read a 2 instead of 1.

Please confirm if this makes sense to you. 

P.S.: It seems weird how such a simple and obvious bug slipped so many eyes during so many years ;-)


Regards,
Ricard

2016-01-12 16:02 GMT+08:00 ExsonQu <[hidden email]>:
*Hi, Richard,*

             Thank you for your feedback.
             I think the error is caused partially due to the last variable
not be refreshed. But there is other problem for this. What is the
transaction type of 8365 and 8367?

            Thanks and best regards!

            Exson



--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Bug-in-GLAccountInquiry-tp4658408p4658461.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

ExsonQu
Administrator
Hi, Richard,

             Thank you for the reply.
           
            Yes, I think it should be type 2 instead of type 1. Otherwise, we can not retrieve a correct data. And the feature is only constraint to bank accounts now.
            I've fixed the variables non refresh bug and commit to trunk. The your previous data still can not show correctly due to the transaction type mismatch -:).

          Thanks and best regards!

         Exson
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

Pak Ricard
Hi Exson:

Thanks for your reply. I already commited the correction of line 214 of PCAuthorizeExpenses.php

Anyway, I'm afraid this bug has more consequences than the detected mess in your mod, as in line 202 we were getting the next transno for type = 2, but we were saving it into DB as type = 1.

So, some rows of banktrans table will have type = 1 and the same transno but they have nothing in common, so info extracted from banktrans can't be trusted 100% if Petty Cash Module has been used

Not sure if we can get a way to "un-mess" the data, without getting more orphaned info

Update manually systype so transno for type = 2 is higher than type 1 or 2.
SELECT all rows in banktrans with texts "Petty cash" AND "ASSIGNCASH" 
For every row
    get a new transno for type = 2
    update the row with type = 2 and new transno
endfor

I'm sorry for this mess. It affects all Assign cash transactions recorded since the beggining of the Petty Cash Module, in 2.010. 

Regards,
Ricard

2016-01-13 10:23 GMT+08:00 ExsonQu <[hidden email]>:
*Hi, Richard,*

             Thank you for the reply.

            Yes, I think it should be type 2 instead of type 1. Otherwise,
we can not retrieve a correct data. And the feature is only constraint to
bank accounts now.
            I've fixed the variables non refresh bug and commit to trunk.
The your previous data still can not show correctly due to the transaction
type mismatch -:).

          Thanks and best regards!

         Exson



--
View this message in context: http://weberp-accounting.1478800.n4.nabble.com/Bug-in-GLAccountInquiry-tp4658408p4658465.html
Sent from the web-ERP-developers mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers


------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
_______________________________________________
Web-erp-developers mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/web-erp-developers
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug in GLAccountInquiry

ExsonQu
Administrator
Hi, Richard,

            There is little chance for this confusion. But I am not sure. Let me think about it again.

            Best regards!

            Exson
Loading...